restaurant_world_setting #6

Merged
Jeonghyeon merged 12 commits from restaurant_world_setting into develop 2025-07-17 02:44:15 +00:00
Owner
No description provided.
iwnc2020 self-assigned this 2025-07-15 04:48:41 +00:00
iwnc2020 added 9 commits 2025-07-15 04:48:41 +00:00
iwnc2020 requested review from Jeonghyeon 2025-07-15 04:48:45 +00:00
iwnc2020 added 1 commit 2025-07-15 05:26:24 +00:00
iwnc2020 added 1 commit 2025-07-16 04:33:59 +00:00
iwnc2020 added 1 commit 2025-07-16 04:34:20 +00:00
Jeonghyeon requested changes 2025-07-17 01:29:30 +00:00
@ -19,3 +19,3 @@
// }
Debug.Log(upperPath);
if (upperPath.Contains("ASSETS/_DDD/_RAW/SPRITES/"))
Collaborator

리터럴 제거하고 메소드 추출해서 재사용하거나 bool 지역변수로 빼서 재사용해주세요.

리터럴 제거하고 메소드 추출해서 재사용하거나 bool 지역변수로 빼서 재사용해주세요.
@ -34,3 +35,3 @@
// 특정 폴더일 때만 작동
if (toPath.StartsWith("Assets/_DDD/_Raw/Sprites/"))
if (upperPath.Contains("ASSETS/_DDD/_RAW/SPRITES/"))
Collaborator

리터럴 제거

리터럴 제거
@ -146,3 +144,3 @@
if (maxSize > 1024)
{
CreateSingleAtlas(filePath, path.Replace("/_Raw/", "/Addressables/") + $"_{fileName}.spriteatlasv2");
CreateSingleAtlas(filePath, path.Replace("/_Raw/", "/_Addressables/") + $"_{fileName}.spriteatlasv2");
Collaborator

리터럴 제거

리터럴 제거
@ -343,3 +341,2 @@
CreateAtlas(Utils.FolderPath(path),
Utils.FolderPath(path).Replace("/_Raw/", "/Addressables/") + ".spriteatlasv2");
//CreatePrefab(path, (path.Replace("/Raw/Sprites/", "/Addressables/") + ".prefab").Replace(".png", ""));
Utils.FolderPath(path).Replace("/_Raw/", "/_Addressables/") + ".spriteatlasv2");
Collaborator

리터럴 제거

리터럴 제거
@ -344,2 +342,2 @@
Utils.FolderPath(path).Replace("/_Raw/", "/Addressables/") + ".spriteatlasv2");
//CreatePrefab(path, (path.Replace("/Raw/Sprites/", "/Addressables/") + ".prefab").Replace(".png", ""));
Utils.FolderPath(path).Replace("/_Raw/", "/_Addressables/") + ".spriteatlasv2");
//CreatePrefab(path, (path.Replace("/Raw/Sprites/", "/_Addressables/") + ".prefab").Replace(".png", ""));
Collaborator

불필요한 코드 레거시 주석 삭제 바람
추후 필요하면 로컬 히스토리 살펴보기

불필요한 코드 레거시 주석 삭제 바람 추후 필요하면 로컬 히스토리 살펴보기
@ -21,0 +46,4 @@
{
if (sprite == null) continue;
var key = sprite.name.Replace("(Clone)", "").Trim();
Collaborator

리터럴 제거, "" 대신 string.Empty 등을 사용.

리터럴 제거, "" 대신 string.Empty 등을 사용.
Jeonghyeon merged commit d43efed5d7 into develop 2025-07-17 02:44:15 +00:00
Jeonghyeon deleted branch restaurant_world_setting 2025-07-17 02:44:16 +00:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: iwnc2020/ProjectDDD#6
No description provided.