iwnc2020/ProjectDDD
2
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

feature/inventory_system #15

Closed
iwnc2020 wants to merge 0 commits from feature/inventory_system into develop
pull from: feature/inventory_system
merge into: iwnc2020:develop
Conversation 0 Commits - Files Changed -
iwnc2020 commented 2025-07-21 11:14:48 +00:00
Owner
Copy Link
No description provided.
iwnc2020 self-assigned this 2025-07-21 11:14:48 +00:00
iwnc2020 added 2 commits 2025-07-21 11:14:48 +00:00
Jeonghyeon requested changes 2025-07-22 01:53:54 +00:00
Assets/_DDD/_Scripts/GameData/InventoryManager.cs Outdated
@ -0,0 +5,4 @@
namespace DDD
{
public class InventoryManager : Singleton<InventoryManager>, IManager
Jeonghyeon commented 2025-07-22 01:53:24 +00:00
Collaborator
Copy Link

GameData 모듈은 불변하는 게임 데이터를 조회만 하는 역할이 좋을 것 같습니다.
게임 진행에 따른 동적인 상태변화는 RestaurantState와 RestaurantController 모듈로 이동하는게 적절할 것 같습니다.
이름도 RestaurantInventory, RestaurantItemData 정도가 적당하지 않을까요?

GameData 모듈은 불변하는 게임 데이터를 조회만 하는 역할이 좋을 것 같습니다. 게임 진행에 따른 동적인 상태변화는 RestaurantState와 RestaurantController 모듈로 이동하는게 적절할 것 같습니다. 이름도 RestaurantInventory, RestaurantItemData 정도가 적당하지 않을까요?
Assets/_DDD/_Scripts/GameData/InventoryManager.cs Outdated
@ -0,0 +55,4 @@
_inventoryItemDatas[id] = new InventoryItemData(id, quantity);
}
EventBus.Broadcast(new InventoryChangedEvent());
Jeonghyeon commented 2025-07-22 01:48:33 +00:00
Collaborator
Copy Link

argument가 필요없는 이벤트라면, 정적 객체 GameEvents.InventoryChangedEvent를 호출하는 식으로 변경해주세요.
매번 new를 부를 필요는 없어보입니다.

argument가 필요없는 이벤트라면, 정적 객체 GameEvents.InventoryChangedEvent를 호출하는 식으로 변경해주세요. 매번 new를 부를 필요는 없어보입니다.
Assets/_DDD/_Scripts/GameData/InventoryManager.cs Outdated
@ -0,0 +81,4 @@
_inventoryItemDatas.Remove(id);
}
EventBus.Broadcast(new InventoryChangedEvent());
Jeonghyeon commented 2025-07-22 01:49:03 +00:00
Collaborator
Copy Link

정적 객체 전달

정적 객체 전달
iwnc2020 added 2 commits 2025-07-22 03:39:03 +00:00
iwnc2020 closed this pull request 2025-07-22 03:55:38 +00:00
iwnc2020 deleted branch feature/inventory_system 2025-07-22 03:55:53 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Jeonghyeon
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
iwnc2020
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: iwnc2020/ProjectDDD#15
No description provided.
Delete Branch "feature/inventory_system"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?