Jeonghyeon
  • Joined on 2025-07-07
Jeonghyeon created pull request iwnc2020/ProjectDDD#9 2025-07-17 03:05:53 +00:00
WIP: 레스토랑 플레이어 무브먼트 리팩토링
Jeonghyeon created branch feature/playermovement_refactoring in iwnc2020/ProjectDDD 2025-07-17 03:04:14 +00:00
Jeonghyeon pushed to feature/playermovement_refactoring at iwnc2020/ProjectDDD 2025-07-17 03:04:14 +00:00
ae05e4ceda 레스토랑 플레이어 무브먼트 리팩토링
Jeonghyeon approved iwnc2020/ProjectDDD#8 2025-07-17 02:45:37 +00:00
event_system
Jeonghyeon pushed to develop at iwnc2020/ProjectDDD 2025-07-17 02:45:12 +00:00
2564b4be67 Merge pull request 'player_polishing' (#7) from player_polishing into develop
47ab5d8a0c 레스토랑 플레이어 매직넘버 데이터화
5c21b07583 누락된 에셋 추가
b273bc04b4 불필요한 데이터 삭제 및 이동
4e8fd18a2a 플레이어 로직 변경에 따른 에셋 추가
Compare 6 commits »
Jeonghyeon deleted branch player_polishing from iwnc2020/ProjectDDD 2025-07-17 02:45:12 +00:00
Jeonghyeon merged pull request iwnc2020/ProjectDDD#7 2025-07-17 02:45:10 +00:00
player_polishing
Jeonghyeon approved iwnc2020/ProjectDDD#7 2025-07-17 02:45:00 +00:00
player_polishing
Jeonghyeon pushed to develop at iwnc2020/ProjectDDD 2025-07-17 02:44:16 +00:00
d43efed5d7 Merge pull request 'restaurant_world_setting' (#6) from restaurant_world_setting into develop
d5f4b54e6b 로직 변경에 따른 에셋 추가
12ff1ab2b9 Addressable에 SpriteAtlas를 등록해서 Sprite를 받아오는 방식으로 로직 변경
bcba4f0436 테스트 id 변경
7e88663e47 flow에 필요한 에셋 추가
Compare 13 commits »
Jeonghyeon deleted branch restaurant_world_setting from iwnc2020/ProjectDDD 2025-07-17 02:44:16 +00:00
Jeonghyeon merged pull request iwnc2020/ProjectDDD#6 2025-07-17 02:44:15 +00:00
restaurant_world_setting
Jeonghyeon commented on pull request iwnc2020/ProjectDDD#7 2025-07-17 01:52:56 +00:00
player_polishing

매직넘버 제거하고 이름을 붙인 지역변수나 필드로 수정

Jeonghyeon commented on pull request iwnc2020/ProjectDDD#7 2025-07-17 01:52:56 +00:00
player_polishing

#if UNITY_EDITOR 등의 전처리 지시 필요

Jeonghyeon commented on pull request iwnc2020/ProjectDDD#7 2025-07-17 01:52:56 +00:00
player_polishing

전처리 필요

Jeonghyeon commented on pull request iwnc2020/ProjectDDD#7 2025-07-17 01:52:56 +00:00
player_polishing

전처리 지시 필요

Jeonghyeon commented on pull request iwnc2020/ProjectDDD#7 2025-07-17 01:52:56 +00:00
player_polishing

매직넘버 제거하고 파라미터화 혹은 프라이빗 필드, 혹은 제대로된 이름이 붙은 지역변수로 변경할것.

Jeonghyeon suggested changes for iwnc2020/ProjectDDD#7 2025-07-17 01:52:56 +00:00
player_polishing
Jeonghyeon commented on pull request iwnc2020/ProjectDDD#6 2025-07-17 01:29:30 +00:00
restaurant_world_setting

리터럴 제거, "" 대신 string.Empty 등을 사용.

Jeonghyeon commented on pull request iwnc2020/ProjectDDD#6 2025-07-17 01:29:30 +00:00
restaurant_world_setting

리터럴 제거하고 메소드 추출해서 재사용하거나 bool 지역변수로 빼서 재사용해주세요.

Jeonghyeon commented on pull request iwnc2020/ProjectDDD#6 2025-07-17 01:29:30 +00:00
restaurant_world_setting

리터럴 제거